Skip to content

Fix exception thrown by Command::run #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix exception thrown by Command::run #287

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

Command::run is doing

try {
     $input->bind($this->definition);
} catch (ExceptionInterface $e) {
     if (!$this->ignoreValidationErrors) {
          throw $e;
    }
}

And the bind method is only throwing ExceptionInterface so the run method is supposed to thrown only ExceptionInterface and not \Exception which is too generic.

This avoid error with static analysis when we ignore some kind of exception thrown.

@VincentLanglet
Copy link
Contributor Author

Friendly ping @ondrejmirtes if you have time to take a look

@ondrejmirtes
Copy link
Member

I have around 70 unread emails in my inbox after vacation, I'm going from the oldest thread, if you ping here, it means I'm gonna look at it last 😊

@VincentLanglet
Copy link
Contributor Author

I have around 70 unread emails in my inbox after vacation, I'm going from the oldest thread, if you ping here, it means I'm gonna look at it last 😊

Oh ok.
Do you getting an email for every created PR/opened issues on every phpstan repository ?

Have good vacation then

@ondrejmirtes
Copy link
Member

Yes, and every comment and every push too 😊

@VincentLanglet
Copy link
Contributor Author

Friendly ping, in case the notification got lost @ondrejmirtes ^^'

@VincentLanglet
Copy link
Contributor Author

I'll close this since it was released in Symfony 4.4, 5.4 and 6.x.
People just have to use the latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @ondrejmirtes